search

ros-industrial / motoman_experimental

Experimental packages for Motoman manipulators within ROS-Industrial
Apache License 2.0
15 stars 32 forks source link

Initial commit for ES165RD-II support (rebased) #49

Closed gavanderhoorn closed 4 years ago

gavanderhoorn commented 4 years ago

Rebased version of #12.

Taking over the review from @shaun-edwards.

Added some commits to fixup minor things.

gavanderhoorn commented 4 years ago

Attribution is retained.

We'll squash-merge this so as to avoid bloating the history.

gavanderhoorn commented 4 years ago

Thanks @marip8 for the original PR.

gavanderhoorn commented 4 years ago

@marip8 wrote:

Sidebar: I have tested/used this URDF with a real ES series robot (see open PR #28) so would it make more sense to move this PR (and #28) to the non-experimental repository?

Yes, we could do that.

Would you be willing to resubmit the mentioned PRs to ros-industrial/motoman?

I'd just take the "current state" of this PR, as-if squashed. We don't necessarily need all the fixup commits.

marip8 commented 4 years ago

I will squash these commits and open a new PR with both models on the other repository

gavanderhoorn commented 4 years ago

Please do keep the PRs separate. So one PR per variant.