search

ros-industrial / motoman_experimental

Experimental packages for Motoman manipulators within ROS-Industrial
Apache License 2.0
15 stars 32 forks source link

Add support for MH80 #52

Open demorise opened 3 years ago

demorise commented 3 years ago

Adding support for MH80 @shaun-edwards @gavanderhoorn @marip8 mh80_collision mh80_visual

EricMarcil commented 3 years ago

I'm not sure why Travis build failed. I was able to build locally using catkin. @gavanderhoorn Can you take a look at this when you have a chance?

robinsonmm commented 3 years ago

@marip8 is there any reason not to merge this PR? Just checking...

gavanderhoorn commented 2 years ago

I've pushed a couple of fixup commits.

I'll also add a few inline comments as there are some things I'm not sure about.

gavanderhoorn commented 2 years ago

CI will not run, as our Travis integration is essentially disabled (in this repository).

I'm going to ignore that here, as we've migrated to GH Actions anyway.

demorise commented 2 years ago

@EricMarcil @gavanderhoorn . I am a bit lost in this conversation. Is there anything I need to do to make this PR move forward?

EricMarcil commented 2 years ago

@demorise Sorry for the delay. Yes, the link_6_t model needed to be moved forward by 0.175 m so that it appear in the correct position. I've just push a commit that corrects the model. If you could please check that it is correct.