search

ros-industrial / noether

Tool path planning and surface segmenter
124 stars 45 forks source link

Updated inclusion of YAML headers #194

Closed marip8 closed 1 year ago

marip8 commented 1 year ago

Updated version of #193

marip8 commented 1 year ago

@marrts please test and let me know if this plus this PR solves your issue

marrts commented 1 year ago

It did not. noether_gui still fails to build. I'm on 3cff4cb87cbf45e21a760e6dd7907b9e604847cd

marrts commented 1 year ago

It did not. noether_gui still fails to build. I'm on 3cff4cb87cbf45e21a760e6dd7907b9e604847cd

Here is my error:

/usr/bin/ld: libnoether_gui.so: undefined reference to `YAML::Node& YAML::Node::operator=<double>(double const&)'
/usr/bin/ld: libnoether_gui.so: undefined reference to `YAML::Node& YAML::Node::operator=<int>(int const&)'
/usr/bin/ld: libnoether_gui.so: undefined reference to `int YAML::Node::as<int>() const'
/usr/bin/ld: libnoether_gui.so: undefined reference to `YAML::Node::~Node()'
/usr/bin/ld: libnoether_gui.so: undefined reference to `double YAML::Node::as<double>() const'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/noether_gui_app.dir/build.make:287: noether_gui_app] Error 1
make[1]: *** [CMakeFiles/Makefile2:139: CMakeFiles/noether_gui_app.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:136: all] Error 2
---
Failed   <<< noether_gui [1min 15s, exited with code 2]
marip8 commented 1 year ago

This error comes from building noether or building something else that links against noether? Seems strange because CI passes here without issue

marrts commented 1 year ago

Well it's telling me that noether_gui is the package that is failing, so I have to assume it's from noether

marrts commented 1 year ago

In a completely new noether only workspace it appears to be working for me. I'm not sure why it is failing for me in my snp workspace, but I guess I'm good with this merging then.

marrts commented 1 year ago

In a completely new noether only workspace it appears to be working for me. I'm not sure why it is failing for me in my snp workspace, but I guess I'm good with this merging then.

It appears to be working fine if I build from the terminal, but it gives me issues when building with Qt Creator. Not sure what is wrong with the environment.

marip8 commented 1 year ago

Okay; I'll merge this and the SNP PR and we can troubleshoot your workspace offline