search

ros-industrial / packet-simplemessage

Wireshark Lua dissector for the ROS-Industrial SimpleMessage protocol
8 stars 10 forks source link

Remove hard-coded byte-sequence len for pos/vel/acc arrays #13

Open gavanderhoorn opened 9 years ago

gavanderhoorn commented 9 years ago

This was (re)introduced in 719fd51a as part of the implementation of the don't display invalid fields configuration item (for #6). Code now (again) assumes 10 items per array, with a byte size of 4 bytes per item. This holds for now, but could change.

simonschmeisser commented 7 years ago

Would be nice to at least have a single constant to change when going from 10 to 20 (yumi)

gavanderhoorn commented 6 years ago

I agree, but the bigger issue is that there is no real 'size' for any of those fields in the protocol, so if we add a pref item, it'll override the size for all packets in the capture, not just those you are referring to.

That might not be that much of a problem though, as it'll rarely happen that two different variants of simple-message are present in the same capture file like that.

gavanderhoorn commented 6 years ago

If you are still interested I would welcome a PR. Otherwise I'll add it to my TODO list, but no guarantees when/if that gets processed.

simonschmeisser commented 6 years ago

I switched to using the default abb_driver on this yumi so it's back to 10 joints. Also my wireshark skills were to weak to actually get this to run :( So no PR in the near future I guess

gavanderhoorn commented 6 years ago

Also my wireshark skills were to weak to actually get this to run :(

are you saying that you could not get the plugin to work at all?

simonschmeisser commented 6 years ago

yes, but I'm not implying that anything is broken necessarily ... I'm just not very skilled in using wireshark

gavanderhoorn commented 6 years ago

Off-topic for this issue, but: installation is really just copying the file to the location indicated in the readme. After that Wireshark should automatically start using the plugin for any traffic on the registered ports (11000, 11002, 50240, 50241). No other configuration is necessary.