ros-industrial / packet-simplemessage

Wireshark Lua dissector for the ROS-Industrial SimpleMessage protocol
8 stars 10 forks source link

Installation instructions out of date #24

Closed CameronDevine closed 5 years ago

CameronDevine commented 5 years ago

The path to place the packet-simplemessage.lua script on Linux is out of date. According to the Wireshark documentation, https://www.wireshark.org/docs/wsug_html_chunked/ChPluginFolders.html, the script should be placed in the ~/.local/lib/wireshark/plugins directory. Therefore, the installation instructions for Linux should read,

cd $PACKET_SIMPLEMESSAGE
mkdir -p ~/.local/lib/wireshark/plugins
cp packet-simplemessage.lua ~/.local/lib/wireshark/plugins
gavanderhoorn commented 5 years ago

The older location still works -- or at least it did last time I checked it -- but the newer locations should indeed be used.

If you could submit a PR that updates the installation instructions I'd merge it.

CameronDevine commented 5 years ago

Based on the documentation I referenced above, I agree that it should still work, however I had to move the script to the new location when installing Wireshark today. I will submit a pull request with this change tomorrow

gavanderhoorn commented 5 years ago

Fixed by #25.