search

ros-industrial / packet-simplemessage

Wireshark Lua dissector for the ROS-Industrial SimpleMessage protocol
8 stars 10 forks source link

Motion Reply subcode parsing is incorrect #31

Open nardavin opened 6 months ago

nardavin commented 6 months ago

There's a typo in the packet parsing file that causes INVALID_DATA_SPEED, INVALID_DATA_ACCEL, and INVALID_DATA_INSUFFICIENT error subcodes to be incorrectly parsed in wireshark. 3013 should resolve to DATA_SPEED, 3014 to DATA_ACCEL, and 3015 to DATA_INSUFFICIENT.

https://github.com/ros-industrial/packet-simplemessage/blob/b3a655b227a76e29912b8148020908202fc9d4cb/packet-simplemessage.lua#L126-L128

gavanderhoorn commented 6 months ago

You're right. Thanks for the report.

Would you be willing to submit a PR?

gavanderhoorn commented 6 months ago

Could also make it part of #28.