search

ros-industrial / robotiq

Robotiq packages (http://wiki.ros.org/robotiq)
BSD 2-Clause "Simplified" License
232 stars 382 forks source link

Issue prevents RVIZ from loading current STL files #65

Closed cpaxton closed 8 years ago

gavanderhoorn commented 8 years ago

Is this to fix a "ascii vs binary stl and solid in the header" problem?

cpaxton commented 8 years ago

That was the goal, yeah.

gavanderhoorn commented 8 years ago

So why close it? :)

cpaxton commented 8 years ago

I'm not sure why the integration is failing or the meshes won't show here on github. It was a pretty minor change: I just got rid of the "solid" and replaced with a "robot" tag.

gavanderhoorn commented 8 years ago

Travis failing is a configuration issue with the repository, not your fault.

[..] or the meshes won't show here on github.

What do you mean?

shaun-edwards commented 8 years ago

@gavanderhoorn, the file's changed tab doesn't show the model diff. The diff is likely empty since there isn't a geometry difference.

@cpaxton, I think this is worth merging if the models don't load in Rviz (that's the whole point of the models).

v4hn commented 8 years ago

We had no problem with these meshes for the last year, i.e. they show(and showed) up in RViz. Hence, I'm not sure what this request is supposed to fix.

@gavanderhoorn could you describe and provide a picture of the problem?

shaun-edwards commented 8 years ago

@cpaxton, is this still an issue or can this PR be closed. @v4hn's comment seems to indicate that it isn't an issue.

cpaxton commented 8 years ago

Closed the issue. It may be a quirk of one of our platforms. We use a lot of custom code, including custom RVIZ forks and ros-hydro. If I notice it in vanilla rviz in ros-indigo I will provide more documentation.