search

ros-industrial / robotiq

Robotiq packages (http://wiki.ros.org/robotiq)
BSD 2-Clause "Simplified" License
232 stars 382 forks source link

Add queue_size to SModelRobotInput publisher #73

Closed Jntzko closed 8 years ago

Jntzko commented 8 years ago

The publisher should be created with an explicit keyword argument 'queue_size'. The queue_size is set to 1, because every message contains all needed informations.

shaun-edwards commented 8 years ago

@Jntzko, thanks for the contribution. Is there a reason a publisher needs to have the queue size set? Do you know what the default behavior is if it's not set?

gavanderhoorn commented 8 years ago

@shaun-edwards: the requirement (or at least: the display of the warning) for queue_size to be set explicitly was introduced with Indigo. See rospy/Overview/Publishers and Subscribers - Publishing to a topic - queue_size: publish() behavior and queuing for a good rationale.

+1 to the fact that this is needed. The size of the queue might need some tweaking, but see the wiki link I posted.

shaun-edwards commented 8 years ago

@Jntzko, thanks for the contribution. @gavanderhoorn, thanks for the link/info. I learned something new. Merging...