search

ros-industrial / robotiq

Robotiq packages (http://wiki.ros.org/robotiq)
BSD 2-Clause "Simplified" License
232 stars 382 forks source link

Indigo devel #77

Closed HashirShafi closed 7 years ago

HashirShafi commented 8 years ago

This PR is intended to solve the CMake error issue of soem package dependency. I am attaching the edited CMakeListst.txt which worked for me. CMakeLists.txt

shaun-edwards commented 8 years ago

@HashirShafi, Thanks for the contribution. Can you please rebase this on the jade-devel? Let me know if you need help with this?

HashirShafi commented 8 years ago

@shaun-edwards I am sorry. I am new to ROS and Github. Do you mean to test it on jade distribution by 'rebase' ?

shaun-edwards commented 8 years ago

@HashirShafi, I'm not sure what happened. It looks like you want to sync the indigo-devel and jade-devel. This needs to be done, but I will do this. Your changes to fix the compile issue seem to have been lost. You can try again, or you can simply send the changes to me and I will create the PR for you.

gavanderhoorn commented 8 years ago

@shaun-edwards: the CMakeLists.txt mentioned in the OP is actually a link to an attachment (ie: just as you would attach an image to an issue). The changes to robotiq_ethercat/CMakeLists.txt are not included in the PR.

HashirShafi commented 8 years ago

@Shaun Edwardsmailto:notifications@github.com, What I have identified so far that it was the dependency issue of soem package. After having cloned the robotiq repository, I typed in the terminal

rosdep install --from-paths /my workspace's src's path/ --ignore-src

This command installed the soem package for me but it was not a catkin package so I changed the CMakeLists.txt of robotiq_ethercat package. I am attaching the modified CMakelists.txt with the email. After doing these changes I built my workspace succesfully.

From: Shaun Edwards notifications@github.com Sent: Tuesday, June 28, 2016 10:54 PM To: ros-industrial/robotiq Cc: HashirShafi; Mention Subject: Re: [ros-industrial/robotiq] Indigo devel (#77)

@HashirShafihttps://github.com/HashirShafi, I'm not sure what happened. It looks like you want to sync the indigo-devel and jade-devel. This needs to be done, but I will do this. Your changes to fix the compile issue seem to have been lost. You can try again, or you can simply send the changes to me and I will create the PR for you.

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ros-industrial/robotiq/pull/77#issuecomment-229208546, or mute the threadhttps://github.com/notifications/unsubscribe/ATOpY5l9XPbJeIBpGPs2yg6CMf7j_PcKks5qQaYhgaJpZM4I-3sp.

shaun-edwards commented 7 years ago

Closing this PR because it is blocking a sync between indigo and jade.