search

ros-industrial / robotiq

Robotiq packages (http://wiki.ros.org/robotiq)
BSD 2-Clause "Simplified" License
232 stars 382 forks source link

Fixed STL solid/binary warnings on load #85

Closed Kukanani closed 7 years ago

Kukanani commented 8 years ago

I used MeshLab to re-open and save all of the visual files for the S-Model gripper. Some of the meshes changed as seen below, however, this was only because I also used MeshLab to remove duplicate vertices. The overall volume of the visual models is the same, as can be seen when using the Revision Slider.

Fixes #84. This is the problem addressed by #65, and I'm not sure why that PR was ever accepted. I've always been taught to treat warnings as errors.

gavanderhoorn commented 8 years ago

Fixes #84. This is the problem addressed by #65, and I'm not sure why that PR was ever accepted.

Afaict, #65 was never merged?

Kukanani commented 7 years ago

Looks like #65 prevented loading for a user with a special case. This issue does not prevent loading in the general case, but causes lots of warnings to be printed to console. Can this be merged?

shaun-edwards commented 7 years ago

Thanks for the contribution....merging.