search

ros-industrial / ros2_canopen

CANopen driver framework for ROS2
https://ros-industrial.github.io/ros2_canopen/manual/rolling/
140 stars 60 forks source link

Fix a number of build warnings #137

Closed hellantos closed 1 year ago

destogl commented 1 year ago

When you are already on fixing warnings, we just learned this week that -Wconversion flag is not set with -Wall – unfortunately the learning was not easy, and we lost a few hours to debugging issues in the tests caused by implicit casting and narrowing types.

I propose to add this here – just to be sure that all castings are used properly – especially since we are converting a lot between doubles and (u)ints.

check here for more details: https://github.com/ros-controls/ros2_control/pull/1053

hellantos commented 1 year ago

@destogl I've made another issue here #135.