search

ros-industrial / ros2_canopen

CANopen driver framework for ROS2
https://ros-industrial.github.io/ros2_canopen/manual/rolling/
131 stars 55 forks source link

Wrong log level on canopen_ros2_control cia402_data.hpp #179

Closed lucasmluza closed 4 months ago

lucasmluza commented 1 year ago

Hello. I notice that in canopen_ros2_control/include/canopen_ros2_control/cia402_data.hpp, at line 66, the log level should be INFO, and not ERROR.

https://github.com/ros-industrial/ros2_canopen/blob/faca7297438bef5d7a986122959988d16a567246/canopen_ros2_control/include/canopen_ros2_control/cia402_data.hpp#L65-L67

    if (!config["node_id"])
    {
      RCLCPP_ERROR(rclcpp::get_logger(joint_name), "No node id for '%s'", joint.name.c_str());
      return false;
    }

    node_id = config["node_id"].as<uint16_t>();
-   RCLCPP_ERROR(
+   RCLCPP_INFO(
      rclcpp::get_logger(joint_name), "Node id for '%s' is '%u'", joint.name.c_str(), node_id);