search

ros-industrial / ros2_canopen

CANopen driver framework for ROS2
https://ros-industrial.github.io/ros2_canopen/manual/rolling/
143 stars 62 forks source link

Configurable SDO timeout #261

Closed gsalinas closed 5 months ago

gsalinas commented 7 months ago

Rather than hardcoding a 20ms timeout for all SDO reads / writes, this PR makes 20ms the default and allows a different value to be specified by setting sdo_timeout_ms in the node definition in bus.yml.

roncapat commented 5 months ago

@hellantos @ipa-nhg sorry for tagging, but it seems to me you are at least some of the maintainers (?) here, at least from some older commits - please otherwise point me to the right people if possible. May I kindly ask if there are any plans to merge for example this PR that I find useful and in general what to expect in the future in terms of package developments or support? is there a roadmap somewhere?

hellantos commented 5 months ago

This looks good to me, @ipa-vsp can you confirm and merge?