ros-industrial / ros2_canopen

CANopen driver framework for ROS2
https://ros-industrial.github.io/ros2_canopen/manual/rolling/
141 stars 60 forks source link

fix ament_export_libraries #45

Closed borongyuan closed 2 years ago

borongyuan commented 2 years ago

I would recommend using ament_cmake_auto to write CMakeLists files. This will greatly simplify CMakeLists files, normalize file directories, and avoid such typo. The downside is that there seems to be a lack of documentation right now, but it doesn't really require much documentation. Here is a gist for reference: https://gist.github.com/dirk-thomas/a76f952d05e7b21b0128

hellantos commented 2 years ago

Thanks for the PR. I will check if and how we can make use of ament_cmake_auto.