Break out GTest into its own package to fix windows CI build failures

ros-industrial / ros_industrial_cmake_boilerplate

Other

16 stars 15 forks source link

Break out GTest into its own package to fix windows CI build failures #18

Closed Levi-Armstrong closed 3 years ago

Levi-Armstrong commented 3 years ago

@marip8 For some reason the current method was causing all of my windows CI to fail. This reverts the changes, but adds gtest as another package which should achieve the same results but fix my windows CI failures.

Levi-Armstrong commented 3 years ago

@marip8 Do you mind reviewing?

Levi-Armstrong commented 3 years ago

@marip8 How does it look now? I will squash merge when approved.

Levi-Armstrong commented 3 years ago

I am currently testing this here

marip8 commented 3 years ago

Other than the README formatting, I think this looks good

Levi-Armstrong commented 3 years ago

@marip8 Thanks, I will wait for confirmation from the Tesseract PR before squash merging.