Is lcov missing as a build_depend?

gavanderhoorn commented 3 years ago

lcov appears to only be listed as a test_depend in the manifest:

https://github.com/ros-industrial/ros_industrial_cmake_boilerplate/blob/25aabced08aff54720215abf2d2adbe42cc3ecf6/ros_industrial_cmake_boilerplate/package.xml#L15

this causes problems for downstream users if they depend on ros_industrial_cmake_boilerplate as part of their own build, as lcov will not be installed at that point.

I believe adding <build_depend>lcov</build_depend> would solve this, but haven't investigated everything closely enough to be absolutely sure.

jbeck28 commented 3 years ago

This worked for me

Levi-Armstrong commented 3 years ago

@gavanderhoorn Usually when I am using these they are done as part of building the unit tests which is why I put them as test_depends. Though I am not sure how ros tools decide to pull the test dependencies. I can add them as build depends

Levi-Armstrong commented 3 years ago

@gavanderhoorn Do you think all of these should also be added as build_depends?

  <test_depend>lcov</test_depend>
  <test_depend>libclang-dev</test_depend>
  <test_depend>iwyu</test_depend>
  <test_depend>cppcheck</test_depend>

Levi-Armstrong commented 2 years ago

@gavanderhoorn friendly ping

ros-industrial / ros_industrial_cmake_boilerplate

Is lcov missing as a build_depend? #41