search

ros-industrial / ros_industrial_cmake_boilerplate

Other
16 stars 14 forks source link

extract_package_metadata doesn't handle semi colons #61

Closed mpowelson closed 2 years ago

mpowelson commented 2 years ago

This description in the package.xml

<description>test; test</description>

gives this error

CMake Error at /home/matthew/code/external/devel/lib/cmake/ros_industrial_cmake_boilerplate/extract_package_metadata.cmake:57 (string):
  string sub-command STRIP requires two arguments.

Removing the semi colon fixes it

marip8 commented 2 years ago

Is this a solvable issue or just a limitation of the CMake commands? If it's just a limitation, then we should just document it on the README and close this issue

jdlangs commented 2 years ago

Likely it just needs some care around making sure the description stays a string and isn't allowed to be treated as a list. I think I touched this last when I fixed it to work with empty descriptions so I can take a quick look.