search

ros-industrial / ros_industrial_cmake_boilerplate

Other
16 stars 14 forks source link

Fix artifacts directory in github actions #77

Closed cschindlbeck closed 1 year ago

marip8 commented 1 year ago

Is this not the solution to the build error? I was trying to figure this out but didn't have more time to look into it more

cschindlbeck commented 1 year ago

i don't think so as 0.4.0 appears to package just fine while everything else upwards doesn't, also since the pipeline does not run on my github or this PR i did not have the confidence to keep this PR open, if you know a way to verify the pipeline i would be happy to have a look at it again

marip8 commented 1 year ago

This may actually solve the issue. This job only runs when tags are created, hence my creation of 4.0.1-5 to test the job. I think you could test by opening this PR against the master branch on your own fork, merging it, then pushing a new tag to your repo and checking the job status. I should have done it this way for the previous few patches

cschindlbeck commented 1 year ago

Ah, just saw the on tags, i pushed a test tag here: https://github.com/cschindlbeck/ros_industrial_cmake_boilerplate/actions/runs/4346943449/jobs/7593640605

It helped to find that i forgot to add the -p option but it appears to work fine

marip8 commented 1 year ago

Looks good to me. Thanks for figuring this out and testing