Add license information badges to readme files

ros-industrial / ros_industrial_issues

Repository for tracking common ROS-Industrial issuses.

3 stars 4 forks source link

Closed ipa-nhg closed 2 years ago

ipa-nhg commented 5 years ago

gavanderhoorn commented 5 years ago

Example:

sshot

gavanderhoorn commented 5 years ago

Automatically crawling for licenses in ROS workspace / environment could be done perhaps using https://github.com/ros-infrastructure/rospkg/pull/143.

130s commented 5 years ago

Although I've been happily using https://github.com/ros-infrastructure/rospkg/pull/143 (and its depended PR https://github.com/ros-infrastructure/rospkg/pull/133) in the internal repos for months, they aren't merged yet so need some setup. I'm happy to help if that's desired.

gavanderhoorn commented 5 years ago

@130s: thanks for the offer.

they aren't merged yet so need some setup

are there any really involved steps, or would it "just" be a matter of merging the PR locally?

130s commented 5 years ago

they aren't merged yet so need some setup
are there any really involved steps, or would it "just" be a matter of merging the PR locally?

I'd say it depends on the platform.

Where dependency is only minimally installed, it usually needs some adhoc setting due to https://github.com/ros-infrastructure/rospkg/issues/142.
- In my experience this is the case for CI where I want to use base Docker image where dependency is only sparsely pre-installed.
If dependency is well-installed, you may use the PR as is.
- Without even merging, you can use just by setting PATH to script and PYTHONPATH to src folder in rospkg.

gavanderhoorn commented 5 years ago

This issue currently lacks an overview of the specific repositories that we'd like to add these badges too. That would first need to be added.

hsd-dev commented 5 years ago

gavanderhoorn commented 5 years ago

Thanks for the many PRs @ipa-hsd.

gavanderhoorn commented 5 years ago

I've unassigned you for now.

ipa-nhg commented 2 years ago

@ipa-hsd @gavanderhoorn I checked all the PRs and all of them are merged or closed because they were superseded by other commits.

I will close this issue for now. @ipa-hsd thanks a lot for your contribution 👍🏽

hsd-dev commented 2 years ago

There was some issue with https://github.com/ros-industrial/robotiq/pull/156 with multiple licenses being added. But seems like no action has been taken for it.

gavanderhoorn commented 2 years ago

Your PR was merged though I believe.