Should we add Probot/Stale to the ros-industrial organization?

ros-industrial / ros_industrial_issues

Repository for tracking common ROS-Industrial issuses.

3 stars 4 forks source link

Should we add Probot/Stale to the ros-industrial organization? #60

Closed Levi-Armstrong closed 5 years ago

Levi-Armstrong commented 5 years ago

I am interested in adding this to several of the repositories that I maintain but wanted to reach out and see if it was ok to add this service to the organization. It does not force every repository to use it, only the ones that add a particular file to the repository similar to travis ci.

Levi-Armstrong commented 5 years ago

Here is the link: https://probot.github.io/apps/stale/

gavanderhoorn commented 5 years ago

It depends a bit on the permissions the app needs.

Personally I'm not a fan of allowing blanket access to all org data for apps, and some do ask quite a bit of access for no apparent reason.

Levi-Armstrong commented 5 years ago

I should of looked deeper but you can add it to individual repositories. The two permissions below are the only ones it requests.

Read access to metadata and single file
Read and write access to issues and pull requests

Levi-Armstrong commented 5 years ago

Is it OK if I add it to the trajopt, tesseract, and ros_qtc_plugin repository?

gavanderhoorn commented 5 years ago

If you're comfortable with that level of access, then sure, go ahead.

Edit: I haven't seen apps that can be added to single repositories of organisations though. They're typically added org-wide, then enabled for specific repositories.

Levi-Armstrong commented 5 years ago

This is what it shows me. It not very clear.

gavanderhoorn commented 5 years ago

yes, that looks like you add it to the organisation and then activate/configure it for specific repositories.

That would be similar to what I've seen with other "apps" (like Travis).

Not sure there is anything that can be done about that though, short of integrating them manually (which for some reason is considered inefficient and is made rather difficult).

Levi-Armstrong commented 5 years ago

Oh, Is there any issue with the permission that have to be granted?

gavanderhoorn commented 5 years ago

Oh, Is there any issue with the permission that have to be granted?

No, they're probably fine.

gavanderhoorn commented 5 years ago

Closing as it seems we've reached a conclusion.

@Levi-Armstrong: I'm not seeing any additional integrations. Did you end up installing Probot or Stale?