ros-industrial / ros_industrial_issues

Repository for tracking common ROS-Industrial issuses.
3 stars 4 forks source link

Increase minimum CMake version to allow builds on Focal Fossa (Noetic) #67

Open gavanderhoorn opened 4 years ago

gavanderhoorn commented 4 years ago

See ros/catkin#1052.

ipa-nhg commented 2 years ago

I created a bash script to automate this, it is quite simple:

#/bin/bash
mkdir /tmp/ros-i
cd /tmp/ros-i
git clone git@github.com:ros-industrial/motoman
git clone git@github.com:ros-industrial/kuka_experimental
git clone git@github.com:ros-industrial/industrial_calibration
git clone git@github.com:ros-industrial/ros_qtc_plugin
git clone git@github.com:ros-industrial/error_classification_server
git clone git@github.com:ros-industrial/error_resolution_diagnoser
git clone git@github.com:ros-industrial/ros_canopen
git clone git@github.com:ros-industrial/abb_librws
git clone git@github.com:ros-industrial/abb_driver
git clone git@github.com:ros-industrial/industrial_core
git clone git@github.com:ros-industrial/fanuc
git clone git@github.com:ros-industrial/fanuc_experimental
git clone git@github.com:ros-industrial/motoman_experimental
git clone git@github.com:ros-industrial/robotiq
git clone git@github.com:ros-industrial/industrial_pcl
git clone git@github.com:ros-industrial/abb_robot_driver
git clone git@github.com:ros-industrial/abb_robot_driver_interfaces
git clone git@github.com:ros-industrial/abb
git clone git@github.com:ros-industrial/industrial_moveit
git clone git@github.com:ros-industrial/universal_robot -b melodic-devel-staging
git clone git@github.com:ros-industrial/ur_msgs
git clone git@github.com:ros-industrial/staubli
git clone git@github.com:ros-industrial/staubli_val3_driver
git clone git@github.com:ros-industrial/staubli_experimental
git clone git@github.com:ros-industrial/abb_experimental

grep -rl 'cmake_minimum_required(VERSION 2.8.3)' . | xargs sed -i 's/cmake_minimum_required(VERSION 2.8.3)/cmake_minimum_required(VERSION 3.0.2)/g'

cd /tmp/ros-i
for DIR in `ls`;
do
    if [ -d $DIR/.git ];
    then
            echo "...Checking changes for $DIR"
            cd $DIR
            git checkout -b CMakeVersionFocal
            git commit -am 'Increase minimum CMake version to allow builds on Focal Fossa (Noetic)'
            git push git@github.com:ipa-nhg/$DIR CMakeVersionFocal
            cd ..
    fi
done

I will open the derived PRs but probably it will not make sense for many of the repos, likely because they contain an old distro version. For those repos without a CI system for focal I will set the PR as draft and ask the maintainer to decided if the PR should be closed or can be set as "ready" and merged.