search

ros-industrial / ros_industrial_issues

Repository for tracking common ROS-Industrial issuses.
3 stars 4 forks source link

ROS2 version of Tolomatic servo driver #70

Closed schornakj closed 3 years ago

schornakj commented 3 years ago

@ben-greenberg and I have been working on a WIP ROS2 version of the ROS-I Tolomatic servo driver package. We want to consolidate our work in an "official" open-source repo, so I'd like to coordinate with the ROS-I organization maintainers on a good way to do this.

Right now the package is somewhat entangled with ROS-specific functionality, since it was originally written exclusively for ROS1. Ideally there should be a ROS-independent pure-C++ driver package and separate thin ROS/ROS2 nodes that expose servo control and status through services and topics, but it'll take some more work to organize things to that point.

One approach would be:

I've been using a similar approach elsewhere (Yak/yak_ros/yak_ros2, for example) and it seems to work well.

We also need to add a new repo maintainer to the tolomatic repo, since I think @wpmccormick isn't active anymore.

gavanderhoorn commented 3 years ago

I can add you as an admin to that repository if you'd like.

Does @wpmccormick no longer work at SwRI, or is he busy with other things?

I'd like to avoid just stepping in and removing people's access if it's not needed.

schornakj commented 3 years ago

@wpmccormick no longer works at SwRI. Ben reached out to him here and it seems like he's busy with other work in any case.

I think it would be OK if I were an admin for that repo.

wpmccormick commented 3 years ago

By all means, remove me as admin. Joe has my full confidence.

BTW ... having fun doing Water/Wastewater systems. So much easier :)

On Thu, Nov 5, 2020 at 4:13 PM Joseph Schornak notifications@github.com wrote:

@wpmccormick https://github.com/wpmccormick no longer works on SwRI. Ben reached out to him here https://github.com/ros-industrial/tolomatic/issues/7and it seems like he's busy with other work in any case.

I think it would be OK if I were an admin for that repo.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ros-industrial/ros_industrial_issues/issues/70#issuecomment-722676234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALAW2AQKX743WHT6SOHMF3SOMPRJANCNFSM4TL2DBQQ .

gavanderhoorn commented 3 years ago

@schornakj: I've setup two teams and made you member of both. The first team has push access, the other admin. Add ppl to the appropriate teams as you see fit. You're also team manager of both teams.

Let me know when creating those new repositories would be necessary.

schornakj commented 3 years ago

@gavanderhoorn Thank you very much!

gavanderhoorn commented 3 years ago

Can this be closed @schornakj ?

schornakj commented 3 years ago

@gavanderhoorn Yes, we have the right access to make the changes we need. I'll let you know separately when we're at a point where we need a new repository.