ros-industrial / ros_industrial_issues

Repository for tracking common ROS-Industrial issuses.
3 stars 4 forks source link

Python scripts should probably avoid hardcoding path to python binary #9

Closed gavanderhoorn closed 10 years ago

gavanderhoorn commented 10 years ago

Python scripts in some of the industrial packages seem to hard code the path to the Python interpreter binary in their shebang line, ie: #!/usr/bin/python vs #!/usr/bin/env python.

While I haven't been able to find a definitive answer, at least in the ROS community it seems it might be better to use the env variant. Seeing as ROS aims to support multiple Linux distributions, each with their own policy regarding Python versioning, the env line seems more appropriate as it is more flexible (always depend on system default interpreter or the one the user has specified).

A short list of some of the packages hardcoding the path:

See also python choice in some of ROS packages on ROS Answers.

gavanderhoorn commented 10 years ago

Not sure about human_tracker: is that still maintained / supported? I can submit a PR for that as well.

shaun-edwards commented 10 years ago

Human tracker will not be included in the ROS-Industrial debs. I'm not sure what it's future is at the moment, so let's leave it off the list for now.

gavanderhoorn commented 10 years ago

Closing this as human_tracker will not be updated. The other packages have been updated.