search

ros-industrial / ros_qtc_plugin

ROS Qt Creator Plug-in (https://ros-qtc-plugin.readthedocs.io)
398 stars 214 forks source link

buildstep configurations are not accessible #444

Closed v4hn closed 3 years ago

v4hn commented 3 years ago

I just wanted to set the number of build jobs in my qt-creator build configuration and found no way to do that. The build step configurations for the ROS build steps have been empty for as long as I've used the plugin. This is what I see in the build config screen over here:

buildstep-config

Notice the various options available in the IncrediBuild step (I just added that for illustration).

Looking at the plugin code though, it looks like there is quite a bit of code dedicated to UI options for these steps including jobs and various others! See here for catkin_tools. But there does not seem to be anything even instantiating the class.

Is this yet another API that got deprecated and removed in qt-creator at some point? I have no idea whether it's one line missing or requires an entire rewrite, but it would be great to see these configurations available!

@christian-rauch @Levi-Armstrong ?

Levi-Armstrong commented 3 years ago

In the older version under the catkin, tools step you could select the Edit... button which would bring this widget up for editing catkin tools profiles.

image

image

christian-rauch commented 3 years ago

It's totally possible that this got removed accidentally by me during one of the many API transitions. I never noticed that, since I am not using that functionality. Do you know with which version this functionality disappeared?

Edit: I tested the old 4.9.2 installer and I see the options there. So this definitely broke with one of the API transitions. But there were 7 of them (4.{10...15}, 5.0), so it will take some time to figure out which update broke this functionality.

Levi-Armstrong commented 3 years ago

I am currently on 4.9.2 which has this functionality.

christian-rauch commented 3 years ago

I assume that this broke with 59ac8cd81323c56b94e49ab88d0aa698a3d8d4ea. It should work with 4.13 and not with 4.14.

christian-rauch commented 3 years ago

@v4hn Can you check if https://github.com/ros-industrial/ros_qtc_plugin/pull/447 solves this issue for you? It should add the configuration widgets again and undo some of the changes from 59ac8cd81323c56b94e49ab88d0aa698a3d8d4ea. You can download the plugin archive from the build artefacts at: https://github.com/ros-industrial/ros_qtc_plugin/actions/runs/1261301357.

Edit: plugin archive from CI: ROSProjectManager-0.4.0-Linux-x86_64.zip