search

ros-industrial / ros_qtc_plugin

ROS Qt Creator Plug-in (https://ros-qtc-plugin.readthedocs.io)
398 stars 214 forks source link

port to Qt Creator 6.0 #456

Closed christian-rauch closed 2 years ago

christian-rauch commented 3 years ago

This is the initial port for Qt Creator 6 Beta. I am going to keep this as a draft until it has been officially released. But you can already review and comment now.

Port for Qt Creator 6.

Notable changes are:

  1. switch to Qt6
  2. temporary deactivation of the ROS Terminal (qtermwidget) due to missing support for Qt6, I tried to use the Qt5 version but this seem to crash Qt Creator with something related to the Qt5 compatibility layer
  3. without qtermwidget, which is not available on Windows, I am also building the Windows plugin in the CI, the plugin itself does not load correctly, presumably because if missing symbols, but having the CI run with MSVC already provides some useful warnings and error messages
christian-rauch commented 2 years ago

@Levi-Armstrong Can you have a look at this PR and suggest a way how we can go forward without the qtermwidget?

christian-rauch commented 2 years ago

@Levi-Armstrong Can you have a look at this? The removal of the qtermwidget5 effectively disables ROSGenericRunStep, but according to https://github.com/ros-industrial/ros_qtc_plugin/issues/459, this is broken anyway for a while now.

I think the "Run Settings" for rosrun, roslaunch, ros2 run, ros2 launch, etc. need to be implemented anyway. So we are not losing any features by removing the qtermwidget5.