search

ros-industrial / siemens_experimental

Apache License 2.0
8 stars 6 forks source link

Indigo release items #5

Open shaun-edwards opened 8 years ago

shaun-edwards commented 8 years ago

The following is a quick list of the items that must be addressed before transitioning to Indigo:

gavanderhoorn commented 8 years ago

Regarding the yaml-cpp changes: if there are no significant functional differences in the rest of the package between the Hydro and the Indigo version, it would perhaps make sense to localise the impact of the changes (ie: move yaml parsing to some helper functions) and use something like:

if(NOT ${YAML_CPP_VERSION} VERSION_LESS "0.5")
  add_definitions(-DHAVE_NEW_YAMLCPP)
endif()

in the CMakeLists.txt together with some conditional inclusion to keep the package compatible with both Hydro and Indigo.