Closed addy1997 closed 4 years ago
Are you wanting to merge this? If so I would recommend placing it in the industrial moveit repo and would be nice if you could add a link in the readme to that demo if you end up creating it there.
Are you wanting to merge this? If so I would recommend placing it in the industrial moveit repo and would be nice if you could add a link in the readme to that demo if you end up creating it there.
Yes I want to merge this with the repo.
based on the title of the PR, this demo program seems to be specific to the UR5 which means that this repository would have to depend on the UR repos to work. Furthermore, the code doesn't really have anything that's stomp specific as it calls the motion planning pipeline through moveit.
based on the title of the PR, this demo program seems to be specific to the UR5 which means that this repository would have to depend on the UR repos to work. Furthermore, the code doesn't really have anything that's stomp specific as it calls the motion planning pipeline through moveit.
Actually, I am sorry to name it wrongly it is not based on stomp. I works well with OMPL.
The code is not intended for UR5 only but can be used with any moveit-supported robot.
On Thu, Oct 17, 2019 at 8:28 PM Jorge Nicho notifications@github.com wrote:
based on the title of the PR, this demo program seems to be specific to the UR5 which means that this repository would have to depend on the UR repos to work. Furthermore, the code doesn't really have anything that's stomp specific as it calls the motion planning pipeline through moveit.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ros-industrial/stomp_ros/pull/12?email_source=notifications&email_token=AHALNOUHDNVY5FISOEEKC2DQPB4TFA5CNFSM4I7YH6YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBQNAPI#issuecomment-543215677, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHALNOW45NDWI6NXXZTK6XDQPB4TFANCNFSM4I7YH6YA .
Nevertheless, the goal position is specific to some urdf so it won't work on any robot. I don't think it makes sense for this demo program to be in this repo
so should i make a pull up request to the other repo u mentioned?
On Fri 18 Oct, 2019 8:31 pm Jorge Nicho, notifications@github.com wrote:
Nevertheless, the goal position is specific to some urdf so it won't work on any robot. I don't think it makes sense for this demo program to be in this repo
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ros-industrial/stomp_ros/pull/12?email_source=notifications&email_token=AHALNOQN6VDSZ2YAVCFGQ6TQPHFWJA5CNFSM4I7YH6YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBUYOCQ#issuecomment-543786762, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHALNORXDYMASJSHSZVV2J3QPHFWJANCNFSM4I7YH6YA .
Hello folks,
This code is about motion planning with collision avoidance incorporated with STOMP. I would like anyone to try it out. I will be really thankful for feedback on working.
Thanks