search

ros-industrial / universal_robot

ROS-Industrial Universal Robots support (https://wiki.ros.org/universal_robot)
1.1k stars 1.04k forks source link

Suggestion: rename repository #381

Open gavanderhoorn opened 6 years ago

gavanderhoorn commented 6 years ago

Simple really (or maybe not so much): rename the repository and metapackage to universal_robots from what it is now (universal_robot).

It's probably lost to history why this package and repository were created as universal_robot, but it's something that's been like that ever since the first version of the driver and description packages was created (eaff5f37).

The company's name is Universal Robots and the package(s) should reflect that.

ipa-nhg commented 5 years ago

@gavanderhoorn I am agree with you For the metapackage is quite trivial: https://github.com/ros-industrial/universal_robot/pull/401. Although til we release once the repo with the new name it doesn't take "real" effect. The repository (and its url) is more sensitive for those that already have a fork and/or a local git clone, but communicating the change in the right channels should be enough.

Note: the wiki site has also to be renamed http://wiki.ros.org/universal_robot

davetcoleman commented 5 years ago

renaming a package on github isn't a big deal because the old name will auto-redirect to the new name, even during git clone

+1

gavanderhoorn commented 5 years ago

This will have to be done tick-tock, in order to not break existing installation instructions.

davetcoleman commented 5 years ago

When you rename a repository, all existing information, with the exception of Project Pages URLs, is automatically redirected to the new name In addition to redirecting web traffic, all git clone, git fetch, or git push operations targeting the previous location will continue to function as if made on the new location.

https://help.github.com/en/articles/renaming-a-repository

gavanderhoorn commented 5 years ago

Thanks @davetcoleman, but I'm well aware of how GH handles repository renames.

My comment was about more than just the name of the repository itself.

fmauch commented 1 year ago

The meta-package itself is renamed already, the ROS Wiki page is renamed and a redirection is in place. So, everything left to do should be actually renaming the repository and afterwards update the docs:

fmauch commented 1 year ago

Removing this from the milestone, as this is not effectively stopping us from releasing.