search

ros-industrial / universal_robot

ROS-Industrial Universal Robots support (https://wiki.ros.org/universal_robot)
1.08k stars 1.04k forks source link

Add convenience macros for description files #562

Closed fmauch closed 3 years ago

fmauch commented 3 years ago

Originally started by @gavanderhoorn this PR aims at providing direct xacro macros for each robot model.

This way, users can easily embed a UR robot into their own robot descriptions without the necessity of providing all xacro arguments, as default values for the respective models are already set.

I mainly open this PR, as I'd like to base #538 on top of those changes. @gavanderhoorn I hope you don't mind hijacking your efforts here.

fmauch commented 3 years ago

Sorry for bothering, but is anything holding this back?

lianghongzhuo commented 3 years ago

Since this pull request has been approved by a reviewer, can anyone have merge permission merge this one?

ljden commented 3 years ago

Bump

dhled commented 3 years ago

Also approving :)

ipa-nhg commented 3 years ago

ping @gavanderhoorn , could you please check the changes proposed here and merge the PR? I have already tested and approved it.

ljden commented 3 years ago

Is there any particular reason this isn't merged?

lianghongzhuo commented 3 years ago

Please merge this

lianghongzhuo commented 3 years ago

Please merge this