ros-industrial / universal_robot

ROS-Industrial Universal Robots support (https://wiki.ros.org/universal_robot)
1.08k stars 1.04k forks source link

Elbow joint limits just +-pi even with ${joint_limited} false #577

Closed vonunwerth closed 3 years ago

vonunwerth commented 3 years ago

Why are the joint position limits of the elbow joint in each arm description set to +-pi even if the joint_limited parameter is false. Should not they be defined as +-2pi regarding the official declarations(https://www.universal-robots.com/media/50880/ur10_bz.pdf) or is that a sort of "trick" to make it easier for moveit to find a IK solution?

 <xacro:unless value="${joint_limited}">
        <limit lower="${-pi}" upper="${pi}" effort="150.0" velocity="3.15"/>

I can see that there is no reason to turn this joint around its own axis, because it would collide with the robots base, but should the problem already be addressed at this level? If someone really doesn't pay attention to self-collisions, then (for whatever reason) they also want to use the full limits. Considering self-collisions, the limits should then be considered at this level one way or the other.

If you want to address this problem already here, it would also be conceivable to limit the joint further to about 170° because already then there is a collision with the base.

gavanderhoorn commented 3 years ago

Because of #265.