search

ros-industrial / universal_robot

ROS-Industrial Universal Robots support (https://wiki.ros.org/universal_robot)
1.05k stars 1.03k forks source link

xacro: double underscores are not supported #582

Closed rhaschke closed 2 years ago

rhaschke commented 2 years ago

Since xacro 1.14.9 (Noetic) or 1.13.13 (Melodic) double underscores in property names are not allowed anymore. This requires the URDF descriptions to be adapted accordingly. See also https://github.com/ros/xacro/issues/282.

rhaschke commented 2 years ago

Looks like underscore names were introduced in the melodic-devel-staging branch only. Thus the Kinetic release isn't yet affected.

gavanderhoorn commented 2 years ago

I believe #579 addresses this.

rhaschke commented 2 years ago

Thanks for linking this PR. I had the impression that this was already addressed, but I'm surprised that the PR isn't yet merged. Feel free to close this issue.