search

ros-industrial / universal_robot

ROS-Industrial Universal Robots support (https://wiki.ros.org/universal_robot)
1.05k stars 1.03k forks source link

added drawing to explain the new data_flow in urdf #591

Open Simon248 opened 2 years ago

Simon248 commented 2 years ago

Related to issue Documentation: ur_description package structure #539

added drawing in readme added jpg of drawing in repo added drawio file in rep (if evolution are needed, can be open in https://app.diagrams.net/)

ipa-nhg commented 2 years ago

@simon248 thanks a lot for your contribution, it is a really nice addition to the documentation of this package.

I would suggest to move the draw to the package ur_description. A READMEmd file can also be added to the folder package to add some text with the context and include the diagram to preview it on GitHub.

lianghongzhuo commented 2 years ago

Thanks for your drawing. It would be better for visualization if you can use SVG file format, as it is scalable and GitHub supports rendering SVG files in the markdown preview.

Simon248 commented 2 years ago

Hi,

@ipa-nhg Thanks for the feedback, modifications done.

RobertWilbrandt commented 1 year ago

Hey, thanks for the contribution. I think the image contains only one error: The ur_macro.xacro file is also in the inc subdirectory. Could you adjust that?

As this is only a documentation change i would not see this as blocking #617 and therefore not put it in the milestone.