search

ros-industrial / universal_robot

ROS-Industrial Universal Robots support (https://wiki.ros.org/universal_robot)
1.05k stars 1.03k forks source link

UR20 description and meshes #657

Closed urrsk closed 6 months ago

urrsk commented 10 months ago

The UR20 meshes are added under Universal Robots A/S’ Terms and Conditions for Use of Graphical Documentation

fmessmer commented 9 months ago

thanks for the URDF and meshes :tada: they work great for us....could we get this merged - and released to Noetic - some time soon?

RobertWilbrandt commented 9 months ago

I agree with merging this to noetic-devel. As there are no further melodic binary releases, people have to build from sources anyway to get this support and using noetic sets the right expectations about maintenance and robustness.

fmauch commented 9 months ago

Alright, I'll merge this on Friday then and start releasing from a noetic branch.

urrsk commented 8 months ago

Please squash the commits when it is ready for getting merged.

fmauch commented 8 months ago

@gavanderhoorn Could you give this another review please?

fmessmer commented 8 months ago

Alright, I'll merge this on Friday then and start releasing from a noetic branch.

what's blocking this PR from merging?

fmauch commented 8 months ago

what's blocking this PR from merging?

A review requesting changes (or a re-review to be more precise, since these comments have been addressed).

urrsk commented 7 months ago

@gavanderhoorn it would valuable if you could fine the time in the near future to review this PR again. I believe requested changes have been addressed. Otherwise please let me know.

gavanderhoorn commented 7 months ago

I've approved the changes to the previous review so as to not block this.

I've left new comments as comments, so they don't block.

fmessmer commented 6 months ago

still eagerly waiting for this to get merged and released :roll_eyes:

fmauch commented 6 months ago

As discussed and requested by UR, I'll leave the license badge point to the online version and merge things as they currently are.