search

ros-industrial / ur_modern_driver

(deprecated) ROS 1 driver for CB1 and CB2 controllers with UR5 or UR10 robots from Universal Robots
Apache License 2.0
302 stars 340 forks source link

Unused min/max_payload parameters #289

Open miguelprada opened 5 years ago

miguelprada commented 5 years ago

This package's launch files expose min_payload and max_payload arguments, which are used to set equally named parameters, but those parameters are not used anywhere.

gavanderhoorn commented 5 years ago

Those were supported in the master version (which got it from ur_driver), but apparently @Zagitta didn't implement the checks:

https://github.com/ros-industrial/ur_modern_driver/blob/77fa08ae9c846344310d3b50824a7affdc3eda47/include/ur_modern_driver/ros/io_service.h#L65-L70

gavanderhoorn commented 5 years ago

I added help wanted as this could be a good first issue for someone to tackle.

gavanderhoorn commented 5 years ago

Did you make any progress here @ben-greenberg?

ben-greenberg commented 5 years ago

I have made progress but some further work and testing is still needed. I will be continuing my work on this.

gavanderhoorn commented 5 years ago

I'm going to unassign this @ben-greenberg.

You're welcome to keep working on it of course.