Open mathias-luedtke opened 5 years ago
Just realised you marked this as WIP. Are you expecting to update it and point to master after merging ros-industrial/industrial_ci#361?
Are you expecting to update it and point to master after merging ros-industrial/industrial_ci#361?
Yes, this was my intention. Of course, it is up to you to merge it (or not)
@miguelprada: I'm thinking I'm going to be OK with merging this PR. What is your opinion?
One reason not to merge it would be that we'd not be running the CI with the build environment users are likely to use. I'm not sure whether that is enough of a problem not to accept the PR though.
One reason not to merge it would be that we'd not be running the CI with the build environment users are likely to use
The new version uses catkin-tools (as before). Colcon is optional (for ROS1) .
One reason not to merge it would be that we'd not be running the CI with the build environment users are likely to use
The new version uses catkin-tools (as before). Colcon is optional (for ROS1) .
Ah, I was unaware of this. Thanks for the clarification.
@miguelprada: :bellhop_bell: ?
https://github.com/ros-industrial/industrial_ci/issues/390