search

ros-industrial / ur_modern_driver

(deprecated) ROS 1 driver for CB1 and CB2 controllers with UR5 or UR10 robots from Universal Robots
Apache License 2.0
302 stars 340 forks source link

migrate to new industrial_ci version #323

Open mathias-luedtke opened 5 years ago

mathias-luedtke commented 5 years ago

https://github.com/ros-industrial/industrial_ci/issues/390

miguelprada commented 5 years ago

Just realised you marked this as WIP. Are you expecting to update it and point to master after merging ros-industrial/industrial_ci#361?

mathias-luedtke commented 5 years ago

Are you expecting to update it and point to master after merging ros-industrial/industrial_ci#361?

Yes, this was my intention. Of course, it is up to you to merge it (or not)

gavanderhoorn commented 5 years ago

@miguelprada: I'm thinking I'm going to be OK with merging this PR. What is your opinion?

One reason not to merge it would be that we'd not be running the CI with the build environment users are likely to use. I'm not sure whether that is enough of a problem not to accept the PR though.

mathias-luedtke commented 5 years ago

One reason not to merge it would be that we'd not be running the CI with the build environment users are likely to use

The new version uses catkin-tools (as before). Colcon is optional (for ROS1) .

gavanderhoorn commented 5 years ago

One reason not to merge it would be that we'd not be running the CI with the build environment users are likely to use

The new version uses catkin-tools (as before). Colcon is optional (for ROS1) .

Ah, I was unaware of this. Thanks for the clarification.

gavanderhoorn commented 4 years ago

@miguelprada: :bellhop_bell: ?