search

ros-industrial / ur_modern_driver

(deprecated) ROS 1 driver for CB1 and CB2 controllers with UR5 or UR10 robots from Universal Robots
Apache License 2.0
302 stars 340 forks source link

Correct frame used for Wrench messages (fix #318) #324

Closed gavanderhoorn closed 5 years ago

gavanderhoorn commented 5 years ago

As per subject.

Followed the suggestion by @miguelprada to use the base frame.

gavanderhoorn commented 5 years ago

Other than the typo that I went ahead and fixed, looks good to me.

ah, yes, I was actually just fixing that.

I'll go ahead and force push to avoid the fixup.

gavanderhoorn commented 5 years ago

I've also dismissed your review by force pushing @miguelprada, sorry about that.

gavanderhoorn commented 5 years ago

bah @ clangformat ..

miguelprada commented 5 years ago

bah @ clangformat ..

Didn't see your comment and just force-pushed a fixup.

gavanderhoorn commented 5 years ago

@miguelprada: force-pushing the branch has dismissed your review (and @jrgnicho's).