ros-infrastructure / bloom

A release automation tool which makes releasing catkin (http://ros.org/wiki/catkin) packages easier.
Other
59 stars 95 forks source link

Failed to generate the Pull Request when #260

Closed thomas-moulard closed 10 years ago

thomas-moulard commented 10 years ago

Apparently, Bloom does not like Unicode too much when it generates GitHub PR:

$  bloom-release --rosdistro hydro --track hydro vision_visp
[...]
<== Pushed tags successfully
==> Generating pull request to distro file located at 'https://raw.github.com/ros/rosdistro/master/hydro/distribution.yaml'
Unified diff for the ROS distro file located at '/tmp/tmpAMEHcM/vision_visp-0.7.2-0.patch':
--- hydro/distribution.yaml
+++ hydro/distribution.yaml
@@ -5364,7 +5364,7 @@
       tags:
         release: release/hydro/{package}/{version}
       url: https://github.com/lagadic/vision_visp-release.git
-      version: 0.7.1-0
+      version: 0.7.2-0
     source:
       type: git
       url: https://github.com/lagadic/vision_visp.git
==> Checking on github for a fork to make the pull request from...
==> Using this fork to make a pull request from: thomas-moulard/rosdistro
==> Cloning thomas-moulard/rosdistro...
Failed to open pull request: UnicodeEncodeError - 'ascii' codec can't encode character u'\xe9' in position 466: ordinal not in range(128)

(FYI \xe9 is "é"... !)

wjwwood commented 10 years ago

I need the debug output, can you please post the full log? It should be in ~/.bloom_logs

thomas-moulard commented 10 years ago

Here is the log: https://gist.github.com/thomas-moulard/9544884

wjwwood commented 10 years ago

Here is an attempt to address this, though I had trouble reproducing the issue: https://github.com/ros-infrastructure/bloom/pull/314

wjwwood commented 10 years ago

Not sure if #314 fully addresses the issue, but if anyone runs into it again, please comment here.