search

ros-infrastructure / bloom

A release automation tool which makes releasing catkin (http://ros.org/wiki/catkin) packages easier.
Other
58 stars 93 forks source link

Have bloom get its defaults for a new track from 'rolling' #599

Open clalancette opened 4 years ago

clalancette commented 4 years ago

Currently, when creating a new track for a package in a new ROS distribution, bloom uses the alphabetically-last version to get the "defaults" for its prompts. However, the alphabetically last version may not be the latest. One example is in https://github.com/ros2-gbp/ament_lint-release/blob/master/tracks.yaml , where prior to 'rolling' being added, the last alphabetically was 'r2b3', which ironically was one of the oldest releases.

Now that we have the ROS 2 'rolling' distribution, alphabetically-last will actually choose 'rolling' for quite a while. But once we get to S-turtle, that will no longer be the case. I'm suggesting that we change bloom to always pull from 'rolling' for the defaults, if it exists, as presumably that will be the latest. If 'rolling' does not exist, then we can fall back to the previous strategy of alphabetically-last.

dirk-thomas commented 4 years ago

The strategy could also leverage the distribution_status available from rosdistro to first consider distro names with the status "rolling" and then the ones with "active". That would avoid hardcoding distro names and ever selecting a non-active distro.

clalancette commented 4 years ago

The strategy could also leverage the distribution_status available from rosdistro to first consider distro names with the status "rolling" and then the ones with "active". That would avoid hardcoding distro names and ever selecting a non-active distro.

Oh yeah, that's a great idea.