search

ros-infrastructure / buildfarm

Build scripts and notes for catkin debian build pipeline.
6 stars 15 forks source link

Generalize status page #104

Closed trainman419 closed 11 years ago

trainman419 commented 11 years ago

Generalize the status page to support non-willow repositories and ARM.

This adds command-line arguments for specifying the repositories, distros, architectures, and/or distro-arch pairs.

This also removes the source columns from the status page, because they were broken, and the code to hide that brokenness didn't generalize well.

tfoote commented 11 years ago

The source columns were explicitly hidden as they will start working when we upgrade the slaves to precise. It's a bug in python-apt.

On Thu, Mar 28, 2013 at 11:50 AM, Austin notifications@github.com wrote:

Generalize the status page to support non-willow repositories and ARM.

This adds command-line arguments for specifying the repositories, distros, architectures, and/or distro-arch pairs.

This also removes the source columns from the status page, because they

were broken, and the code to hide that brokenness didn't generalize well.

You can merge this Pull Request by running

git pull https://github.com/trainman419/catkin-debs master

Or view, comment on, or merge it at:

https://github.com/willowgarage/catkin-debs/pull/104 Commit Summary

  • Generalize status page.

File Changes

  • M buildfarm/apt_root.pyhttps://github.com/willowgarage/catkin-debs/pull/104/files#diff-0(5)
  • M buildfarm/status_page.pyhttps://github.com/willowgarage/catkin-debs/pull/104/files#diff-1(30)
  • M scripts/generate_status_page.pyhttps://github.com/willowgarage/catkin-debs/pull/104/files#diff-2(43)

Patch Links:

trainman419 commented 11 years ago

My farm runs precise, and I when I enable the source columns, they are completely blank.

dirk-thomas commented 11 years ago

The source columns must be kept. As soon as we stop using Lucid on the buildfarm these columns will be reenabled (and yes, they have been working before and are only disabled).

trainman419 commented 11 years ago

The source columns weren't working because they were hardcoded to pull source versions from the amd64 branch of the repo. Added a patch that fixes that; source columns working and present on my farm now.

dirk-thomas commented 11 years ago

Hydro seems to not have source columns. Can this be related to your changes?

tfoote commented 11 years ago

I had an issues where I could see src in hydro but not in groovy. But all of a sudden groovy had source columns too. I think it's a caching type issue.

ahendrix commented 11 years ago

The old source columns were hidden using jQuery, which caches the table state in a cookie on the client side. This will persist for the cookie timeout of about a day.