The generated HTML status page is really slow to load

ros-infrastructure / buildfarm

Build scripts and notes for catkin debian build pipeline.

6 stars 15 forks source link

The generated HTML status page is really slow to load #149

Closed mikepurvis closed 10 years ago

mikepurvis commented 11 years ago

Massive multi-second pause as the JavaScript crunches through this page. There are a number of ways in which it could be simplified way down:

Reduce dependency on JS for rendering: it's only truly needed for table sorting, and there are lighter ways to do that than jQuery.
Handle styling entirely from CSS.
Eliminate unnecessary wrapper divs to lighten the HTML load.

I can work on this stuff if there'd be interest in a PR for it.

dirk-thomas commented 11 years ago

Yes, we would be happy about any pull request which makes it faster (as long as it keeps the available functionality of search / ordering).

mikepurvis commented 11 years ago

Awesome, I'll see what I can do.

mikepurvis commented 11 years ago

Okay, I've cut down the page by about 75%, and removed all of the onready JavaScript. I've also fixed the widths of several of the columns, which gives the browser a much better time with progressive rendering.

Preview can be viewed here. Still need to do the generated CI urls, fix the legend, restore the search and sort functionality, etc, but none of those should impact the overall snappiness of the page, which is much improved over the current state of affairs, I think.

Tested so far in Chrome, Safari, Firefox. This will never work in IE6 and other legacy browsers, due to extensive use of the nth-child pseudoselector.

dirk-thomas commented 11 years ago

Looks great so far. Looking forward for it. Thank you for your effort!

mikepurvis commented 10 years ago

(Closing this for now; discussion can continue in the PR)