search

ros-infrastructure / buildfarm

Build scripts and notes for catkin debian build pipeline.
6 stars 15 forks source link

Fix undefined name 'URLError' and use new style exceptions #223

Open cclauss opened 6 years ago

cclauss commented 6 years ago

flake8 testing of https://github.com/ros-infrastructure/buildfarm on Python 2.7.14

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./buildfarm/storm.py:154:16: F821 undefined name 'URLError'
        except URLError, ex:
               ^
./buildfarm/storm.py:163:16: F821 undefined name 'URLError'
        except URLError, ex:
               ^
2     F821 undefined name 'URLError'
cclauss commented 6 years ago

Is there a reason not to merge these changes before archiving?

tfoote commented 6 years ago

In general I'd rather not merge this unless it's tested. And as far as I know the API that this is hitting has likely evolved since last tested so keeping this clearly as a snapshot from a few years ago better communicates the state of the system.