ros-infrastructure / buildfarm_deployment

Apache License 2.0
30 stars 39 forks source link

upgrade master to Java 8 #144

Closed dirk-thomas closed 6 years ago

dirk-thomas commented 7 years ago

In order to leverage all the configuration options described in https://jenkins.io/blog/2016/11/21/gc-tuning/

This would certainly help with the repeated crashed of the master.

nuclearsandwich commented 6 years ago

Resolved now that Xenial is the default.

There is a GC tuning discussion specific to build.ros.org in the production configuration repository.

dirk-thomas commented 6 years ago

Is the task for actually using Java 8 specific options like the GC tuning ticketed anywhere? If not I would suggest to keep this one open until that has been done.

nuclearsandwich commented 6 years ago

Is the task for actually using Java 8 specific options like the GC tuning ticketed anywhere?

I literally referenced that issue in my comment closing the issue. Here is a direct link that will be inaccessible to folks outside OSRF https://github.com/osrf/buildfarm_deployment_config/issues/16

dirk-thomas commented 6 years ago

I literally referenced that issue in my comment closing the issue.

Your previous comment only mentions a "tuning discussion" so it was not obvious that there is a ticket tracking this.

Thanks for adding the link to the ticket (even when it is not public). I am sure it will help future readers to find the follow up work.

nuclearsandwich commented 6 years ago

Your previous comment only mentions a "tuning discussion" so it was not obvious that there is a ticket tracking this.

Apologies for the 'tude. I'm definitely reaching the end of a long week. In the past I've tried to avoid links in public-facing projects to private ones as it hurts readability for the majority of participants. But I should get better about either back-referencing the public issue from the private one so that individuals with access will see it or posting links but clarifying their visibility so participants without access will know that the link is inaccessible rather than removed.