[GithubPR plugin] crash with JsonParseException on processing response from PR status update

[mikaelarguedas]

Looks to be because the id is bigger than the allowed range for an int. Example job: http://build.ros.org/job/Ipr__nodelet_core__ubuntu_trusty_amd64/47/console

Reduced error log snippet,

Caused by: com.fasterxml.jackson.core.JsonParseException: Numeric value (4305206855) out of range of int
 at [Source: {"url":"https://api.github.com/repos/ros/nodelet_core/statuses/40b8211021f8baab0d3cc36e0e0391f9f27d0ed0","id":4305206855,"state":"success","description":"Build finished. ","target_url":"http://build.ros.org/job/Ipr__nodelet_core__ubuntu_trusty_amd64/47/","context":"Ipr__nodelet_core__ubuntu_trusty_amd64","created_at":"2017-11-08T21:24:31Z","updated_at":"2017-11-08T21:24:31Z","creator":{"login":"ros-pull-request-builder","id":7094544,"avatar_url":"https://avatars0.githubusercontent.com/u/7094544?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-pull-request-builder","html_url":"https://github.com/ros-pull-request-builder","followers_url":"https://api.github.com/users/ros-pull-request-builder/followers","following_url":"https://api.github.com/users/ros-pull-request-builder/following{/other_user}","gists_url":"https://api.github.com/users/ros-pull-request-builder/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-pull-request-builder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-pull-request-builder/subscriptions","organizations_url":"https://api.github.com/users/ros-pull-request-builder/orgs","repos_url":"https://api.github.com/users/ros-pull-request-builder/repos","events_url":"https://api.github.com/users/ros-pull-request-builder/events{/privacy}","received_events_url":"https://api.github.com/users/ros-pull-request-builder/received_events","type":"User","site_admin":false}}; line: 1, column: 121]

@nuclearsandwich FYI

[dirk-thomas]

This requires GitHub API Plugin 1.90 (we are currently using 1.86). See https://issues.jenkins-ci.org/browse/JENKINS-47601

[nuclearsandwich]

There's an issue posted with 1.89 and 1.90 https://issues.jenkins-ci.org/browse/JENKINS-47848

The reporter gets a null pointer exception on each PR. Should keep an eye on that before upgrading to fix these as the build does not fail and the commit status is able to post.

Edit: Subscribed to that issue so I can keep an eye on it.

[dirk-thomas]

Should we try to upgrade to check that the referenced issue actually affects us?

[nuclearsandwich]

Waiting on a release with this PR merged https://github.com/kohsuke/github-api/pull/396

If we're waiting too long and I can drain the queue of other pressing matters we could build the plugin bundle ourselves.

[dirk-thomas]

If we're waiting too long and I can drain the queue of other pressing matters we could build the plugin bundle ourselves.

kohsuke/github-api#395 already references a custom build version of the plugin. But before going that route I think it makes the most sense to actually comment on the pending PR to raise awareness and get the maintainer to merge and release it upstream. Therefore I just commented on the upstream ticket.

[dirk-thomas]

The fix has been released in GitHub API version 1.92.

[dirk-thomas]

That version has never been released and then the repository was moved. The problem is tracked in jenkinsci/github-api-plugin#19.

[dirk-thomas]

github-api version 1.95 is available as of today.

[nuclearsandwich]

Both the GitHub API and GitHub pull request builder plugins are being updated to their latest version in #207. The pull request builder plugin is now recommending that people migrate to the GitHub Branch Source but I haven't yet evaluated whether it will meet our needs.