Closed dirk-thomas closed 6 years ago
This change will need to be manually propagated to buildfarm master hosts since re-running puppet on them is not safe (#160).
@dirk-thomas am I correct in thinking we want to deploy this on build.ros.org and build.ros2.org as well?
we want to deploy this on build.ros.org and build.ros2.org as well?
A bunch of dev jobs may become unstable with that change, should we notify ROS maintainers before deploying ?
Is any part of the infrastructure using this branch or can it be safely deleted?
am I correct in thinking we want to deploy this on build.ros.org and build.ros2.org as well?
Yes.
A bunch of dev jobs may become unstable with that change, should we notify ROS maintainers before deploying ?
I wouldn't announce it specifically. We announced it for Kinetic. That the regex missed some is a fix which I would say is fine to deploy.
@nuclearsandwich What is the timeline to deploy this change?
@nuclearsandwich What is the timeline to deploy this change?
If there's team consensus that it doesn't need an announcement, I'll deploy it this morning.
fine by me :+1:
Updated on build.ros2.org and build.ros.org.
Addresses ros2/build_cop#73.
The following messages are being ignored since we currently pass some CMake variables to all packages even though they are only expected by some packages:
The change has already been deployed on ci.ros2.org.