search

ros-infrastructure / buildfarm_deployment

Apache License 2.0
30 stars 39 forks source link

improve CMake regex to detect messages without filename:linenumber #169

Closed dirk-thomas closed 6 years ago

dirk-thomas commented 6 years ago

Addresses ros2/build_cop#73.

The following messages are being ignored since we currently pass some CMake variables to all packages even though they are only expected by some packages:

Manually-specified variables were not used by the project: ...

The change has already been deployed on ci.ros2.org.

nuclearsandwich commented 6 years ago

This change will need to be manually propagated to buildfarm master hosts since re-running puppet on them is not safe (#160).

nuclearsandwich commented 6 years ago

@dirk-thomas am I correct in thinking we want to deploy this on build.ros.org and build.ros2.org as well?

mikaelarguedas commented 6 years ago

we want to deploy this on build.ros.org and build.ros2.org as well?

A bunch of dev jobs may become unstable with that change, should we notify ROS maintainers before deploying ?

Is any part of the infrastructure using this branch or can it be safely deleted?

dirk-thomas commented 6 years ago

am I correct in thinking we want to deploy this on build.ros.org and build.ros2.org as well?

Yes.

A bunch of dev jobs may become unstable with that change, should we notify ROS maintainers before deploying ?

I wouldn't announce it specifically. We announced it for Kinetic. That the regex missed some is a fix which I would say is fine to deploy.

dirk-thomas commented 6 years ago

@nuclearsandwich What is the timeline to deploy this change?

nuclearsandwich commented 6 years ago

@nuclearsandwich What is the timeline to deploy this change?

If there's team consensus that it doesn't need an announcement, I'll deploy it this morning.

mikaelarguedas commented 6 years ago

fine by me :+1:

nuclearsandwich commented 6 years ago

Updated on build.ros2.org and build.ros.org.