ros-infrastructure / buildfarm_deployment

Apache License 2.0
30 stars 39 forks source link

master deployment: usermod: group 'docker' does not exist #172

Closed gavanderhoorn closed 6 years ago

gavanderhoorn commented 6 years ago

I'm not sure, but it would seem the jenkins user is being added to the docker group before it exists:

/Stage[main]/Profile::Jenkins::Master/File[/var/lib/jenkins/nodeMonitors.xml] (info): Scheduling refresh of Service[jenkins]
/Stage[main]/Profile::Jenkins::Master/Exec[jenkins docker membership]/returns (notice): usermod: group 'docker' does not exist
Puppet (err): /usr/sbin/usermod -aG docker jenkins returned 6 instead of one of [0]
/Stage[main]/Profile::Jenkins::Master/Exec[jenkins docker membership]/returns (err): change from notrun to 0 failed: /usr/sbin/usermod -aG docker jenkins returned 6 instead of one of [0]

Not a puppet expert at all, but it would appear the jenkins user is a prerequisite already (here).

buildfarm_deployment at 3da95258c079452de52083cc071167ec90bdb15f on a fresh Ubuntu Server 16.04 amd64 VM.

gavanderhoorn commented 6 years ago

Looks like 9ac6091f8f68636dc89bfeee0b04353ac57dbc0a and 394ba825acd51e32b0aa862022c5e81c2e99e8fc remedy this.

No problems with adding jenkins to the docker group so far.

gavanderhoorn commented 6 years ago

51498187d78c156f23be810002fd8f0a9fb63a43 now fixes this in master.

Closing.