fixing newlines when generating squid-in-a-can service file

[jonazpiazu]

I was getting errors when trying to deploy the agent:

2018-01-10 12:30:13 +0100 Puppet (err): Could not start Service[docker-squid-in-a-can]: Execution of '/bin/systemctl start docker-squid-in-a-can' returned 1: Failed to start docker-squid-in-a-can.serv
See system logs and 'systemctl status docker-squid-in-a-can.service' for details.
2018-01-10 12:30:13 +0100 /Stage[main]/Profile::Squidinacan/Docker::Run[squid-in-a-can]/Service[docker-squid-in-a-can]/ensure (err): change from stopped to running failed: Could not start Service[dock
See system logs and 'systemctl status docker-squid-in-a-can.service' for details.

# systemctl status docker-squid-in-a-can.service
● docker-squid-in-a-can.service - Daemon for squid-in-a-can
   Loaded: error (Reason: Invalid argument)
   Active: inactive (dead)

ene 10 12:30:13 xxxx systemd[1]: [/etc/systemd/system/docker-squid-in-a-can.service:19] Unbalanced quoting, ignoring: "/usr/bin/docker run          --net host -m 0b -e DISK_CACHE_SIZE=50000 -e M
ene 10 12:30:13 xxxx systemd[1]: [/etc/systemd/system/docker-squid-in-a-can.service:20] Missing '='.
ene 10 12:32:21 xxxx systemd[1]: [/etc/systemd/system/docker-squid-in-a-can.service:19] Unbalanced quoting, ignoring: "/usr/bin/docker run          --net host -m 0b -e DISK_CACHE_SIZE=50000 -e M
ene 10 12:32:21 xxxx systemd[1]: [/etc/systemd/system/docker-squid-in-a-can.service:20] Missing '='.
ene 10 12:45:02 xxxx systemd[1]: [/etc/systemd/system/docker-squid-in-a-can.service:19] Unbalanced quoting, ignoring: "/usr/bin/docker run          --net host -m 0b -e DISK_CACHE_SIZE=50000 -e M
ene 10 12:45:02 xxxx systemd[1]: [/etc/systemd/system/docker-squid-in-a-can.service:20] Missing '='.

[nuclearsandwich]

Thanks for the contribution. On sight looks good to me. I'm hoping to test reproduction and fixes for other recently reported issues this afternoon and I'll add this to the list.

[gavanderhoorn]

🛎

[nuclearsandwich]

Thanks for the reminder @gavanderhoorn. Toward the end of last week I was pulled away working on issues bootstrapping artful and bionic for ROS Melodic and that'll have most of my attention early this week as well.

[gavanderhoorn]

Just performed an agent deployment. Without this I run into the exact error @jonazpiazu reports in his OP.

I had to merge #189 as well.

[nuclearsandwich]

Thanks again @jonazpiazu.