ros-infrastructure / buildfarm_deployment

Apache License 2.0
30 stars 39 forks source link

Run docker image prune every night at midnight. #182

Closed nuclearsandwich closed 6 years ago

nuclearsandwich commented 6 years ago

As discovered today, the master host was doing nothing to clean up stale images and the sheer volume of them was affecting docker performance.

Pruning dangling images resolved the performance issues.

With this puppet change newly provisioned master hosts will prune dangling images every night at midnight. build.ros.org will require a manual update to the crontab in order to receive the same update because of #160 .

gavanderhoorn commented 6 years ago

With this merged I seem to no longer be able to deploy repo hosts:

/Stage[main]/Profile::Jenkins::Agent/Cron[docker_cleanup_images]/ensure (notice): created
Puppet (err): Puppet::Util::FileType::FileTypeCrontab could not write jenkins-agent: Broken pipe
/Stage[main]/Profile::Jenkins::Agent/Cron[docker_cleanup_images] (err): Could not evaluate: Puppet::Util::FileType::FileTypeCrontab could not write jenkins-agent: Broken pipe

In the session where I started reconfigure.bash repo I see:

The user jenkins-agent cannot use this program (crontab)

Not sure whether that is a coincidence or actually related.

gavanderhoorn commented 6 years ago

Possibly related: #187.