search

ros-infrastructure / buildfarm_deployment

Apache License 2.0
30 stars 39 forks source link

agent: cleanup_docker_images arguments are hard-coded #190

Open gavanderhoorn opened 6 years ago

gavanderhoorn commented 6 years ago

The arguments to the cleanup_docker_images.py script are currently hard-coded (10% and 50 (GB?)):

https://github.com/ros-infrastructure/buildfarm_deployment/blob/2a3d6b409c0e85336ecbcd6e7a3663f913872e27/modules/profile/manifests/jenkins/agent.pp#L118-L127

Should these come from the jenkins::nodeMonitor::minimum_disk_space hiera key?

tfoote commented 6 years ago

They should be related but should be different. The minimum_disk_space is when jenkins will take the machine offline. This threshold should be set higher so that it never reaches the minimum_disk_space and goes offline.

Changing these to be parameters would be great. Generally we adjust the minimum disk_space to be under the above. And note that due to lag in the cleanup process it may need to be significantly below cleanup trigger threshold.