ros-infrastructure / buildfarm_deployment

Apache License 2.0
30 stars 39 forks source link

Reconcile plugins with production build.ros.org. #195

Closed nuclearsandwich closed 6 years ago

nuclearsandwich commented 6 years ago

Synchronizes plugins to install with build.ros.org using plugin script.

Removed plugins since sync:

Updated plugins since sync

Downgraded plugins since sync

Other changes

nuclearsandwich commented 6 years ago

I'm not entirely sure why the removed plugins were removed but as they don't appear to be used in production, we probably won't miss them on new deployments.

For the updates, script-security is one to pay attention to, but the changes between those versions is fairly minor:

token-macro moved to the latest version which fixes a conflict with docker in pipeline builds (a problem we don't have since we do not use pipeline)

workflow-cps (Pipeline: Groovy) changes are also minor and don't affect our usage as we don't currently use pipeline jobs.

The workflow job downgrade is the most confusing. 2.12 is the first version requiring Jenkins 2.60+ and downgrading could have been the result of the earlier plugin version being migrated from the trusty buildfarm by mistake.

The only plugins changed above which appear in ros_buildfarm configuration files are PrioritySorter, which doesn't change version, and script-security, where ros_buildfarm has the updated version resulting from this change.

nuclearsandwich commented 6 years ago

On a clean test deploy there is one difference from our current production server which is that script-security no longer depends on bouncycastle-api (though many other plugins still do).

I think it's safe to incorporate this change into the PR since it won't change anything about our production instance and I'm starting a plugin upgrade test run for #193

   ::jenkins::plugin { 'script-security':
     version => '1.34',
-    require => [ Jenkins::Plugin['bouncycastle-api'] ]
+    require => [  ]
   }