ros-infrastructure / buildfarm_deployment

Apache License 2.0
30 stars 39 forks source link

Fix 'master' proxy vhost config (avoid: "proxy setup broken") #215

Closed gavanderhoorn closed 5 years ago

gavanderhoorn commented 5 years ago

This is for #212.

These were the minimum changes I had to make to the master proxy vhost configuration to make Jenkins happy about the proxy config of the master host.

Based on the puppet docs about apache: Configuring virtual hosts.

gavanderhoorn commented 5 years ago

Note: I've not "deploy-tested" this, but reverse-engineered it from a deployment that doesn't show the notice.

nuclearsandwich commented 5 years ago

Thanks @gavanderhoorn. I have to do a test deployment today for #211 and I'll include this in my deployment branch to see that it succeeds.

nuclearsandwich commented 5 years ago

This worked great in my test deployments. Thanks for this fix.